Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument improvements, cosmetic changes #60

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

boksanns94
Copy link

Hey Werner,
I found your script very useful for monitoring synology devices. Wanted to suggest changes that would make running the script more modular.

CHANGES:

  • Changed some arguments to make them all optional and keyword arguments, since (in my case) we have a bunch of synology devices and there are different confiurations among them (regarding privacy being enabled or not, different ports, usernames, passwords etc.)
  • Did cosmetic changes. Made script more compliant with PEP8 and implemented f-string formatting instead of concatenation and format-strings.
  • Moved "ExitCode" function so its declared before it is used.
  • Renamed "snmpget" and "snmpwalk" to "snmp_get" and "snmp_walk".
  • Added spaces around math symbols (+, /, etc.)

These are the things I changed.
Regads

@boksanns94 boksanns94 changed the title Improvements snmpv3 Argument improvements, cosmetic changes Apr 23, 2024
@boksanns94 boksanns94 marked this pull request as draft April 23, 2024 08:17
@boksanns94 boksanns94 marked this pull request as ready for review April 23, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant