Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questionnnaire Details working again in the new way in AnswerQuestionsForm #18

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

SailingSteve
Copy link
Member

AnswerQuestionsForm did rely on Actions that were no longer working after the changeover, then the last bit of Actions were tracked down and eliminated in files where they did not do anything (as of the December 28th fork).

…sForm

AnswerQuestionsForm did rely on Actions that no longer worked, then the last bit of Actions tracked down and eliminated in files where they did not do anything as of the December 28th fork.
…sForm

AnswerQuestionsForm did rely on Actions that no longer worked, then the last bit of Actions tracked down and eliminated in files where they did not do anything as of the December 28th fork.
Copy link
Member

@DaleMcGrew DaleMcGrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you @SailingSteve!

</InstructionsWrapper>
)}
<TitleWrapper>
{questionnaire && questionnaire.questionnaireTitle}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason we put the {questionnaire.questionnaireTitle && ( outside the <TitleWrapper> styled div is because it has a margin-bottom that pushes down the page. If there is no questionnaireTitle for example, we don't want that margin-bottom affecting the page.

@DaleMcGrew DaleMcGrew merged commit a9b361f into wevote:develop Jan 25, 2025
0 of 2 checks passed
@SailingSteve SailingSteve deleted the steveStaffClientJan24=8pm branch February 8, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants