Introduced ConnectDispatch and apiDataCacheReducer. Organizing organized API data into ‘apiDataCache’ dictionary. (and more) #21
Conversation
…zed API data into ‘apiDataCache’ dictionary. Temporarily forcing react-query to always go to the network while we stabilize new data flow. Still upgrading Questionnaire to new approach. Still reviewing and moving edit mutations into models folder. Commented out many console.log lines. Reordered attributes in TextFields in EditPersonForm to alphabetical.
There was a problem hiding this comment.
If this causes endless loop, there most likely is a problem in a useEffect after a query.
There was a problem hiding this comment.
This still seems like a wasteful pattern. If you have the person object that is current enough to display it, why would you extract the id, and look the person up again in the function. I think this should be fixed now, so it does get propagated by copying the pattern.
There was a problem hiding this comment.
This seems broken, the passed in parameters in useFetchData are for search parameters on the API URL (or post params after my next checkin). Are you sure this is doing what you wanted? It might be the cause of other problems.
There was a problem hiding this comment.
Refetching can't be the right way to go. I'm sure it fixes the symptoms, but destroys one of the key values in ReactQuery ... serving api queries from cache. This needs to be solved before we go on, and copy that pattern elsewhere. I can work on this.
Introduced ConnectDispatch and apiDataCacheReducer. Organizing organized API data into ‘apiDataCache’ dictionary. Temporarily forcing react-query to always go to the network while we stabilize new data flow. Still upgrading Questionnaire to new approach. Still reviewing and moving edit mutations into models folder. Commented out many console.log lines. Reordered attributes in TextFields in EditPersonForm to alphabetical.