First steps toward verify email address #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useFetchData now takes a METHOD parameter to handle get/push Login has been updated, but still needs both the client and server to run in SSL/TLS to be able to send emails. Many lint fixes "Dependency cycle" errors were fixed by pulling some functions that did need access to ConnectAppContext outside of files that did not, and were included in ConnectAppContext and some other places other places -- I'm not attached to this form of refactor if someone has a better way to avoid "Dependency cycle"s Added back (in parallel to the takes an id approach) to allow determining the "FullNamePreferred" string within maps ... getFullNamePreferredPerson = (person)
useFetchData now takes a METHOD parameter to handle get/push Login has been updated, but still needs both the client and server to run in SSL/TLS to be able to send emails. Many lint fixes "Dependency cycle" errors were fixed by pulling some functions that did need access to ConnectAppContext outside of files that did not, and were included in ConnectAppContext and some other places other places -- I'm not attached to this form of refactor if someone has a better way to avoid "Dependency cycle"s Added back (in parallel to the takes an id approach) to allow determining the "FullNamePreferred" string within maps ... getFullNamePreferredPerson = (person)
useFetchData now takes a METHOD parameter to handle get/push Login has been updated, but still needs both the client and server to run in SSL/TLS to be able to send emails. Many lint fixes "Dependency cycle" errors were fixed by pulling some functions that did need access to ConnectAppContext outside of files that did not, and were included in ConnectAppContext and some other places other places -- I'm not attached to this form of refactor if someone has a better way to avoid "Dependency cycle"s Added back (in parallel to the takes an id approach) to allow determining the "FullNamePreferred" string within maps ... getFullNamePreferredPerson = (person)
DaleMcGrew
approved these changes
Feb 5, 2025
| searchResults: [], | ||
| }; | ||
|
|
||
| // These are the "AppContextValues" (i.e., global state variables) used in the PersonModel |
There was a problem hiding this comment.
Should be TaskModel instead of PersonModel in the comment
| @@ -1,7 +1,6 @@ | |||
| import React from 'react'; | |||
| import styled from 'styled-components'; | |||
| import { renderLog } from '../../common/utils/logging'; | |||
| import QuestionnaireResponsesList from '../Questionnaire/QuestionnaireResponsesList'; | |||
| import PersonProfile from './PersonProfile'; | |||
There was a problem hiding this comment.
I think we want to leave import QuestionnaireResponsesList from '../Questionnaire/QuestionnaireResponsesList'; in here but commented out since we want to uncomment <QuestionnaireResponsesList /> as soon as that component is running again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useFetchData has been updated to take a METHOD parameter to handle get/push Login , but still needs both the client and server to run in SSL/TLS to be able to send emails.
Many lint fixes
"Dependency cycle" errors were fixed by pulling some functions that did need access to ConnectAppContext outside of files that did not, and were included in ConnectAppContext and some other places other places -- I'm not attached to this form of refactor if someone has a better way to avoid "Dependency cycle"s
Added back
getFullNamePreferredPerson(person)in parallel to the "takes an id approach" to allow determining the "FullNamePreferred" string within maps or other places where global state can not be accessed.