Added reset password, which required a lot of changes and refactors #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a very messy merge... This is 95% done, but checking in so that we don't diverge so much again. We diverged a bit with admin rights for sessions. I left all the new stuff in parallel with the old stuff (server and client) and I'll migrate over to the new way represented as captureAccessRightsData on the client side. Still need to change over the MUI styles in the ResetYourPassword.jsx from MUI templates to our styles (they look different, and the difference does not add value). Navigating to /Tasks currently leaves the HeaderBar menu confused, will fix this. Spurious "Please sign in" after resetting password, will fix this. More testing needed -- the steps are pretty complex, with the need for immediate `useRef()` variables in some places to avoid (always losing) race conditions.
DaleMcGrew
approved these changes
Feb 26, 2025
| ${(largefont) ? 'font-size: 1.1em;' : 'font-size: .8em;'} | ||
| ${(titlecell) ? '' : 'font-weight: 550;'} | ||
| border-bottom: ${(props) => (props?.$titleCell ? ';' : '1px solid #ccc;')} | ||
| font-size: ${(props) => (props?.$largefont ? '1.1em;' : '.8em;')}; |
There was a problem hiding this comment.
I would prefer to only pass in the property names if they have a value, like this:
${(props) => (props?.$titleCell ? '' : 'border-bottom: 1px solid #ccc;')}
${(props) => (props?.$titleCell ? '' : 'font-weight: 550;')}
One can never be sure that Firefox or Opera will treat properties defined like this as "don't do anything", so I'd rather not send this css to the DOM:
border-bottom: ;
font-weight: ;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a very messy merge...
This is 95% done, but checking in so that we don't diverge so much again.
We diverged a bit with admin rights for sessions. I left all the new stuff in parallel with the old stuff (server and client) and I'll migrate over to the new way represented as captureAccessRightsData on the client side.
Still need to change over the MUI styles in the ResetYourPassword.jsx from MUI templates to our styles (they look different, and the difference does not add value).
Navigating to /Tasks currently leaves the HeaderBar menu confused, will fix this.
Spurious "Please sign in" after resetting password, will fix this.