Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset password works when signed in or not signed in #36

Merged
merged 12 commits into from
Mar 6, 2025

Conversation

SailingSteve
Copy link
Member

@SailingSteve SailingSteve commented Mar 2, 2025

The race conditions and hanging tab (which was due to a strange bug if you use a html form tag without a submit in React).
Uses viewerAccessRights to determine admin like rights.
There is a new "Create Account for Someone Else" button for users with admin like rights, that allows them to create
a person, but not verify their emails. When that new user logs in with the credentials that they were sent, they will have to verify their email at that time.

There might be some edge cases, but it is ready to go.

The race conditions and hanging tab (which was due to a strange bug if you use a <form> with out a submit in React).
There are still some clean up items to do:
1) Create person when an admin, without requiring a password verification -- but in any case a password verfication will still be required on the first login by the new staff person.
2) Escaping out of the creation/verification/reset process without completing all the steps
3) Staying signed in after a password reset

This is still an ongoing development ... only bother merging for now, if you have merges you want to commit.
The race conditions and hanging tab (which was due to a strange bug if you use a <form> with out a submit in React).
There are still some clean up items to do:

1) Create person when an admin, without requiring a password verification -- but in any case a password verification will still be required on the first login by the new staff person.

2) Escaping out of the creation/verification/reset process without completing all the steps

3) Staying signed in after a password reset

This is still an ongoing development ... only bother merging for now, if you have merges you want to commit.
The race conditions and hanging tab (which was due to a strange bug if you use a <form> with out a submit in React).
There are still some clean up items to do:

1) Create person when an admin, without requiring a password verification -- but in any case a password verification will still be required on the first login by the new staff person.

2) Escaping out of the creation/verification/reset process without completing all the steps

3) Staying signed in after a password reset

This is still an ongoing development ... only bother merging for now, if you have merges you want to commit.
…f you use a html form tag without a submit in React).

Uses viewerAccessRights to determine admin like rights.
There is a new "Create Account for Someone Else" button for users with admin like rights, that allows them to create
a person, but not verify their emails.  When that new user logs in with the credentials that they were sent, they will have to verify their email at that time.
There might be some edge cases, but it is ready to go.
…f you use a html form tag without a submit in React).

Uses viewerAccessRights to determine admin like rights.
There is a new "Create Account for Someone Else" button for users with admin like rights, that allows them to create
a person, but not verify their emails.  When that new user logs in with the credentials that they were sent, they will have to verify their email at that time.
There might be some edge cases, but it is ready to go.
…f you use a html form tag without a submit in React).

Uses viewerAccessRights to determine admin like rights.
There is a new "Create Account for Someone Else" button for users with admin like rights, that allows them to create
a person, but not verify their emails.  When that new user logs in with the credentials that they were sent, they will have to verify their email at that time.
There might be some edge cases, but it is ready to go.
…f you use a html form tag without a submit in React).

Uses viewerAccessRights to determine admin like rights.
There is a new "Create Account for Someone Else" button for users with admin like rights, that allows them to create
a person, but not verify their emails.  When that new user logs in with the credentials that they were sent, they will have to verify their email at that time.
There might be some edge cases, but it is ready to go.
…f you use a html form tag without a submit in React).

Uses viewerAccessRights to determine admin like rights.
There is a new "Create Account for Someone Else" button for users with admin like rights, that allows them to create
a person, but not verify their emails.  When that new user logs in with the credentials that they were sent, they will have to verify their email at that time.
There might be some edge cases, but it is ready to go.
…f you use a html form tag without a submit in React).

Uses viewerAccessRights to determine admin like rights.
There is a new "Create Account for Someone Else" button for users with admin like rights, that allows them to create
a person, but not verify their emails.  When that new user logs in with the credentials that they were sent, they will have to verify their email at that time.
There might be some edge cases, but it is ready to go.
…f you use a html form tag without a submit in React).

Uses viewerAccessRights to determine admin like rights.
There is a new "Create Account for Someone Else" button for users with admin like rights, that allows them to create
a person, but not verify their emails.  When that new user logs in with the credentials that they were sent, they will have to verify their email at that time.
There might be some edge cases, but it is ready to go.
…f you use a html form tag without a submit in React).

Uses viewerAccessRights to determine admin like rights.
There is a new "Create Account for Someone Else" button for users with admin like rights, that allows them to create
a person, but not verify their emails.  When that new user logs in with the credentials that they were sent, they will have to verify their email at that time.
There might be some edge cases, but it is ready to go.
…f you use a html form tag without a submit in React).

Uses viewerAccessRights to determine admin like rights.
There is a new "Create Account for Someone Else" button for users with admin like rights, that allows them to create
a person, but not verify their emails.  When that new user logs in with the credentials that they were sent, they will have to verify their email at that time.
There might be some edge cases, but it is ready to go.
@DaleMcGrew
Copy link
Member

👍

@DaleMcGrew DaleMcGrew merged commit 2a575be into wevote:develop Mar 6, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants