Meta: Review Draft infrastructure #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/whatwg.org#197 and whatwg/meta#92 for details. This also updates the web-platform-tests URL.
|
Please do not merge this yet, but please do review. I'd especially appreciate review of the |
annevk
added
the
do not merge yet
annevk
commented
May 29, 2018
Makefile
Outdated
|
|
||
| review: index.bs | ||
| curl --remote-name --fail https://resources.whatwg.org/build/review.sh | ||
| EXTRA_FILES="images/*.*" bash ./review.sh |
There was a problem hiding this comment.
I'm guessing this EXTRA_FILES thing isn't needed here since review.sh just copies and modifies. It's not actually for building (that's done on the server).
There was a problem hiding this comment.
Right, looks like this can be removed
domenic
removed
the
do not merge yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/whatwg.org#197 and
whatwg/meta#92 for details.
This also updates the web-platform-tests URL.