Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editorial] Fix build issues from recent updates to bikeshed #1804

Merged
merged 2 commits into from
Jan 21, 2025
Merged

[Editorial] Fix build issues from recent updates to bikeshed #1804

merged 2 commits into from
Jan 21, 2025

Conversation

nidhijaju
Copy link
Contributor

@nidhijaju nidhijaju commented Jan 21, 2025 •
edited by pr-preview bot
Loading

@nidhijaju
Copy link
Contributor Author

@annevk I think bikeshed was recently updated, which causes the fetch spec to not build anymore. This PR fixes the issues to help it build again. Please take a look.

annevk
annevk approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@annevk annevk merged commit 07662d3 into whatwg:main Jan 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nidhijaju @annevk