use offset when caching TOC info

thomasvs/morituri#92
whipper-team · Nov 29, 2015 · d83e2fe · d83e2fe
1 parent 468d6cb
commit d83e2fe
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 14 deletions.
diff --git a/morituri/common/program.py b/morituri/common/program.py
@@ -151,29 +151,39 @@ def function(r, t):
         assert toc.hasTOC()
         return toc
 
-    def getTable(self, runner, cddbdiscid, mbdiscid, device):
+    def getTable(self, runner, cddbdiscid, mbdiscid, device, offset):
         """
         Retrieve the Table either from the cache or the drive.
 
         @rtype: L{table.Table}
         """
         tcache = cache.TableCache()
         ptable = tcache.get(cddbdiscid, mbdiscid)
+        itable = None
+        tdict = {}
 
-        if not ptable.object:
-            self.debug('getTable: cddbdiscid %s, mbdiscid %s not in cache, '
+        # Ingore old cache, since we do not know what offset it used.
+        if type(ptable.object) is dict:
+            tdict = ptable.object
+
+            if offset in tdict:
+                itable = tdict[offset]
+
+        if not itable:
+            self.debug('getTable: cddbdiscid %s, mbdiscid %s not in cache for offset %s, '
                 'reading table' % (
-                cddbdiscid, mbdiscid))
+                cddbdiscid, mbdiscid, offset))
             t = cdrdao.ReadTableTask(device=device)
             runner.run(t)
-            ptable.persist(t.table)
-            self.debug('getTable: read table %r' % t.table)
+            itable = t.table
+            tdict[offset] = itable
+            ptable.persist(tdict)
+            self.debug('getTable: read table %r' % itable)
         else:
-            self.debug('getTable: cddbdiscid %s, mbdiscid %s in cache' % (
-                cddbdiscid, mbdiscid))
-            ptable.object.unpickled()
-            self.debug('getTable: loaded table %r' % ptable.object)
-        itable = ptable.object
+            self.debug('getTable: cddbdiscid %s, mbdiscid %s in cache for offset %s' % (
+                cddbdiscid, mbdiscid, offset))
+            self.debug('getTable: loaded table %r' % itable)
+
         assert itable.hasTOC()
 
         self.result.table = itable
@@ -182,8 +192,6 @@ def getTable(self, runner, cddbdiscid, mbdiscid, device):
             itable.getMusicBrainzDiscId())
         return itable
 
-    # FIXME: the cache should be model/offset specific
-
     def getRipResult(self, cddbdiscid):
         """
         Retrieve the persistable RipResult either from our cache (from a

diff --git a/morituri/rip/cd.py b/morituri/rip/cd.py
@@ -109,7 +109,7 @@ def do(self, args):
 
         self.itable = self.program.getTable(self.runner,
             self.ittoc.getCDDBDiscId(),
-            self.ittoc.getMusicBrainzDiscId(), self.device)
+            self.ittoc.getMusicBrainzDiscId(), self.device, self.options.offset)
 
         assert self.itable.getCDDBDiscId() == self.ittoc.getCDDBDiscId(), \
             "full table's id %s differs from toc id %s" % (