Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented layout limit #202

Closed
wants to merge 1 commit into from

Conversation

webstack9
Copy link

Fixes #3
Fixes #200
Hi @Nyratas , I was trying to follow instruction from issue 200, this patch should be able to provide flexible layout with limit.

@Petoches
Copy link

Petoches commented Jul 14, 2020

Yet #200 isn't a issue, it's a working pull request, you just changed how it behaved but the result is the same.

@webstack9
Copy link
Author

HI @Petoches , @Nyratas , may bad. Knowing how old is issue 3, I was thinking that pull request 200 was abended, my mistake I was seeing conflict message , and did not check conversation time.
Layout limits is very important for my project where I am using flexible, and reading yours conversation i wanted to try to help as well supporting this great package.
Yesterday whole day I was trying to make digitaloptimist/nova-translatable field validation work when inside flexible , and while I had this code opened and not have any progress with nova-translatable , I wanted to make my day better reverting my focus and layout limits.

As I see now that this is duplicate PR I will cancel this pull request.

@webstack9 webstack9 closed this Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to only allow X numbers of layout instances
2 participants