Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing default getOSFileInfo implementation #137

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

tryggvil
Copy link
Contributor

Implementation of getOSFileInfo for other platforms such as wasm

@willscott
Copy link
Owner

Is your use case just for wasm?

the stub for windows is probably the 'safe' default case - because there isn't a guarantee in the default case that the fields you use off of syscall.Stat_t will exist. If you want to have this build as a wasm-specific implementation, that would be okay.

@tryggvil
Copy link
Contributor Author

Yes my case right now is specifically wasm.
So I updated to have a specific implementation that works on wasm and fall back to the same implementation as windows.

@tryggvil
Copy link
Contributor Author

Also updated go-billy to v5.6.0

@willscott willscott merged commit eb20e67 into willscott:master Oct 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants