Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in column_format using test column #59

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Bug in column_format using test column #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc13423
Bug in column_format using test column
s7clarke10 Oct 30, 2023
4af803f
Bumping versions, adding change log.
s7clarke10 Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# tap-mssql 2.2.1 2023-10-30

* Bug Fix. Removing test code which slipped into the release, and adjusting offending code with correct dynamic column name.

# tap-mssql 2.2.0 2023-08-23

This feature increases support for SQL Datatypes.
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "tap-mssql"
version = "2.2.0"
version = "2.2.1"
description = "A pipelinewise compatible tap for connecting Microsoft SQL Server"
authors = ["Rob Winters <[email protected]>"]
license = "GNU Affero"
Expand Down
2 changes: 1 addition & 1 deletion tap_mssql/sync_strategies/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def prepare_columns_sql(catalog_entry, c):
"""
elif sql_data_type == 'datetimeoffset':
return f"""case when {column_name} is not null then
CONVERT(VARCHAR,dt_offset_col,127)
CONVERT(VARCHAR,{column_name},127)
else null end
"""

Expand Down