Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: codecov fix and rc workflow tweak (WPB-8645) #3219

Merged
merged 9 commits into from
Jul 23, 2024
Merged

ci: codecov fix and rc workflow tweak (WPB-8645) #3219

merged 9 commits into from
Jul 23, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jul 22, 2024 •
edited by github-actions bot
Loading

EpicWPB-8645 [Android] Infrastructure code and developer experience

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Tweaking config for RC merge queue

Causes (Optional)

Checks status not passing due to timeout, due to RC workflow building 3 flavors

Solutions

  • Increase a bit the timeout of the merge queue before failing
  • Remove internal bundle build, this artifact is not used, taking CI time
  • Rollback codecov action to working commit, since it is broken in version 4.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Jul 22, 2024
@yamilmedina yamilmedina marked this pull request as ready for review July 22, 2024 16:04
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-release-pr-3219.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3219.apk is available for download

@yamilmedina yamilmedina requested review from vitorhugods, ohassine, alexandreferris, a team, MohamadJaara and saleniuk and removed request for a team July 22, 2024 16:11
yamilmedina
yamilmedina commented Jul 22, 2024
View reviewed changes
.github/workflows/gradle-run-unit-tests.yml
@@ -75,7 +75,7 @@ jobs:
merge-multiple: true

- name: Upload code coverage to codecov
uses: codecov/codecov-action@v4.5.0
uses: codecov/codecov-action@ab904c41d6ece82784817410c45d8b8c02684457
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last working version of codecov, rollback for now, since 4,x are broken codecov/codecov-action#1463

@echoes-hq echoes-hq bot added the echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast label Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-release-pr-3219.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3219.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-release-pr-3219.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3219.apk is available for download

@yamilmedina yamilmedina requested a review from Garzas July 23, 2024 06:37
@yamilmedina yamilmedina changed the title ci: codecov and actions grouping (WPB-8645) ci: codecov fix and rc workflow tweak (WPB-8645) Jul 23, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-release-pr-3219.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3219.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Jul 23, 2024
Merged via the queue into release/candidate with commit 9da047b Jul 23, 2024
15 of 16 checks passed
@yamilmedina yamilmedina deleted the fix/mergeuquerc branch July 23, 2024 08:28
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
@yamilmedina @github-actions
ci: codecov fix and rc workflow tweak (WPB-8645) (#3219)
f3cb358
@github-actions github-actions bot mentioned this pull request Jul 23, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@Garzas Garzas Garzas approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@vitorhugods vitorhugods Awaiting requested review from vitorhugods

@ohassine ohassine Awaiting requested review from ohassine

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

Assignees

@yamilmedina yamilmedina

Labels
echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yamilmedina @alexandreferris @Garzas @saleniuk