Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to later redis chart with an image containing fewer CVEs #4440

Merged
merged 6 commits into from
Feb 13, 2025

Conversation

jschaul
Copy link
Member

@jschaul jschaul commented Feb 3, 2025

Context https://wearezeta.atlassian.net/browse/WPB-15658

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 3, 2025
@jschaul jschaul force-pushed the upgrade-redis-ephemeral branch from a833d7a to e6d40c5 Compare February 4, 2025 10:44
changelog
@jschaul jschaul force-pushed the upgrade-redis-ephemeral branch from e6d40c5 to 95ee8e7 Compare February 4, 2025 10:46
@jschaul jschaul requested review from battermann and akshaymankar and removed request for battermann February 11, 2025 17:02
# tlsCaSecretRef:
# name: <secret-name>
# key: <ca-attribute>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannon doesn't talk to redis, no need for this config block.

@jschaul jschaul marked this pull request as ready for review February 11, 2025 17:06
@jschaul jschaul changed the title Try if we can upgrade to latest redis chart Upgrade to later redis chart with an image containing fewer CVEs Feb 11, 2025
@jschaul jschaul requested a review from supersven February 12, 2025 16:34
@jschaul
Copy link
Member Author

jschaul commented Feb 13, 2025

Update: tested again, gundeck connects sucessfully to redis. CI is also green.

Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jschaul jschaul merged commit 6fe0220 into develop Feb 13, 2025
10 checks passed
@jschaul jschaul deleted the upgrade-redis-ephemeral branch February 13, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants