Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helmfile destroy that was missing an env variable #4450

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Fix helmfile destroy that was missing an env variable #4450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6132243
Fix helmfile destroy that was missing an env variable
jschaul Feb 12, 2025
3d99ac9
one more env variable
jschaul Feb 12, 2025
e0aeec9
no need for manual ingress class deletion
jschaul Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5-internal/helmfile-destroy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix issue with cleanup of resources after integration tests, namely fix 'helmfile destroy'
5 changes: 2 additions & 3 deletions hack/bin/integration-teardown-federation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ export FEDERATION_DOMAIN_1="."
export FEDERATION_DOMAIN_2="."
export FEDERATION_DOMAIN_BASE_1="."
export FEDERATION_DOMAIN_BASE_2="."
export FEDERATION_CA_CERTIFICATE="."
export ENTERPRISE_IMAGE_PULL_SECRET="."

KUBERNETES_VERSION_MAJOR="$(kubectl version -o json | jq -r .serverVersion.major)"
KUBERNETES_VERSION_MINOR="$(kubectl version -o json | jq -r .serverVersion.minor)"
Expand All @@ -28,7 +30,4 @@ fi
. "$DIR/helm_overrides.sh"
helmfile --environment "$HELMFILE_ENV" --file "${TOP_LEVEL}/hack/helmfile.yaml" destroy --skip-deps --skip-charts --concurrency 0 || echo "Failed to delete helm deployments, ignoring this failure as next steps will the destroy namespaces anyway."

kubectl delete ingressclass "nginx-$NAMESPACE_1" || true
kubectl delete ingressclass "nginx-$NAMESPACE_2" || true

kubectl delete namespace "$NAMESPACE_1" "$NAMESPACE_2"