Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement author profiles #1366

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Implement author profiles #1366

wants to merge 5 commits into from

Conversation

TheOtterlord
Copy link
Member

@TheOtterlord TheOtterlord commented Jan 6, 2025 •
edited
Loading

screenshots

image
image

Browser Test Checklist

I have tested this PR on at least three of the following browsers:

  • Chrome / Chromium
  • Firefox
  • Android Firefox
  • Safari
  • iOS Safari

@netlify Netlify
Copy link

netlify bot commented Jan 6, 2025 •
edited
Loading

✅ Deploy Preview for astro-www-2 ready!

Name Link
🔨 Latest commit aba5c18
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/6789289d4acf960008c98c04
😎 Deploy Preview https://deploy-preview-1366--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 5 paths audited
Performance: 97 (🟢 up 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 96 (🟢 up 4 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TheOtterlord TheOtterlord marked this pull request as draft January 6, 2025 23:43
delucis
delucis reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool work @TheOtterlord! Left some notes based on our discussions and also a couple of design thoughts.

src/pages/themes/author/[username]/[...page].astro Outdated Show resolved Hide resolved
src/pages/themes/_components/ThemeCard.astro Outdated Show resolved Hide resolved
src/components/Profile.astro Outdated Show resolved Hide resolved
src/components/Profile.astro Outdated Show resolved Hide resolved
src/components/Profile.astro Outdated Show resolved Hide resolved
src/components/Profile.astro Outdated Show resolved Hide resolved
@TheOtterlord TheOtterlord marked this pull request as ready for review January 16, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheOtterlord @delucis