Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alternative selector script #4628

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use alternative selector script #4628

wants to merge 3 commits into from

Conversation

gosha212
Copy link
Contributor

@gosha212 gosha212 commented Nov 3, 2024

Description

  • This pull request addresses the issue described here: #<?>

In this pull request, I have …


For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@gosha212 gosha212 requested a review from d4vidi as a code owner November 3, 2024 21:47
Copy link
Contributor

@asafkorem asafkorem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gosha212 is that the solution we're moving forward or we're still testing this approach?
Anyhow if it works on Android, and the same script from iOS, let's plan together how we can do that from the same source (JS level)

/**
* Finds multiple elements given a locator strategy.
*/
public static Atom<List<ElementReference>> findMultipleElementsDetox(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for this method I see lots of methods here that we're not using, copied from the original that we're still using. Can we keep only the specific custom method we're using?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still WIP @asafkorem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants