Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way the initial notification is extracted from intent at #966

Conversation

kristofb
Copy link

@kristofb kristofb commented May 3, 2023

application startup.

Tested on different Android versions up to 13

@skinsapp
Copy link

skinsapp commented Jun 14, 2023

Well done! This works for me on Android 13. Without it, Notifications.getInitialNotification absolutely does not work.

Please merge.

@greenimpala
Copy link

greenimpala commented Jun 15, 2023

For me this works on the very first notification when the app in installed. Once the app is open and force quit, subsequent notifications end up undefined again.

Copy link

@numandev1 numandev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working good

@kristofb kristofb force-pushed the hotfix/proper-initial-notification-on-android-13 branch from 16b6408 to 62f2cd8 Compare July 17, 2023 13:44
@kristofb
Copy link
Author

I just rebased my branch on master. No more changes, for me, this hotfix is working well based on master (release 4.3.5)

@DanielEliraz
Copy link
Collaborator

DanielEliraz commented Jul 20, 2023

@kristofb what about the case @greenimpala wrote:

For me this works on the very first notification when the app in installed. Once the app is open and force quit, subsequent notifications end up undefined again.

@DanielEliraz
Copy link
Collaborator

hey, this change was added in #983 and released in 5.0.0. please verify it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants