Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coldcard: fix a bug introduced by rust-bitcoin upgrade #102

Merged

Conversation

pythcoiner
Copy link
Contributor

rust-bitcoin has introduced a breaking change in DerivationPath serialization, leading m/ have been dropped, this PR implement a fix that accept both w/ and w/o leading /m

see this issue on rust-bitcoin side

Copy link
Member

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with liana-gui

@edouardparis edouardparis merged commit 4d9ca5d into wizardsardine:master Feb 6, 2025
7 checks passed
@nondiremanuel nondiremanuel added this to the v10 Liana async-hwi milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants