Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial GitHub actions (Linux, Mac) #176

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

cconlon
Copy link
Member

@cconlon cconlon commented Feb 14, 2024

This PR adds GitHub actions for automated testing against various JDK distributions and versions. Current testing includes:

wolfSSL ./configure --enable-jni:

  • Test on both Linux (ubuntu-latest) and Mac OSX (macos-latest)
  • Oracle JDK (17, 21)
  • Zulu JDK (8, 11, 17, 21)
  • Corretto JDK (8, 11, 17, 21)
  • Microsoft JDK (11.0.19, 17.0.7, 21.0.0)

wolfSSL ./configure --enable-jni --enable-all:

  • Test on both Linux (ubuntu-latest) and Mac OSX (macos-latest)
  • Just a sanity check with --enable-all used, so only currently testing Zulu JDK 11

@cconlon cconlon self-assigned this Feb 14, 2024
@cconlon cconlon force-pushed the github-actions branch 2 times, most recently from 3acea82 to 9b76aff Compare February 14, 2024 00:21
@cconlon cconlon assigned JacobBarthelmeh and unassigned cconlon Feb 14, 2024
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to have issues running. The github actions test should run on this PR here when opened.

@cconlon
Copy link
Member Author

cconlon commented Feb 14, 2024

Hi @JacobBarthelmeh, after bouncing back and forth some ideas with Andras, my current understanding is that GitHub actions will not run on the first PR that adds them, unless there is a base action in the repository already. Once the base action is in place to test on PRs, new PRs that modify the actions will test those modified changes.

Andras and I tested this by merging in a simple action with #177, then rebasing this PR on master kicked off all the tests included in this PR change as we would expect.

I think this can also be seen if you look back at the first PR for other repos that added their GitHub actions. You'll see that no actions ran on those PRs either:

wolfSSL/wolfMQTT#256
wolfSSL/wolfssh#350

@cconlon cconlon assigned JacobBarthelmeh and unassigned cconlon Feb 14, 2024
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cconlon

@JacobBarthelmeh JacobBarthelmeh merged commit 0e4953f into wolfSSL:master Feb 14, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants