Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wolfjsse: auto-enable SNI for HttpsURLConnection #253

Merged

Conversation

gasbytes
Copy link
Contributor

@gasbytes gasbytes commented Feb 5, 2025

Enable SNI automatically when detecting HttpsURLConnection's unique initialization pattern, fixing ImpactOnSNI test while preserving default SNI behavior for SSL sockets.

Enable SNI automatically when detecting HttpsURLConnection's unique initialization pattern, fixing ImpactOnSNI test while preserving default SNI behavior for SSL sockets.
@gasbytes gasbytes force-pushed the HttpsURLConnection/ImpactOnSNI-patch branch from 217b65b to d075893 Compare February 5, 2025 14:24
Copy link
Member

@cconlon cconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gasbytes, looks good. Assign over to me when ready for merge.

@cconlon cconlon assigned cconlon and gasbytes and unassigned cconlon Feb 5, 2025
@gasbytes gasbytes assigned cconlon and unassigned gasbytes Feb 5, 2025
@cconlon cconlon merged commit 45810c8 into wolfSSL:master Feb 5, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants