Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udate Readme and UI #348

Merged
merged 5 commits into from
Jun 23, 2024
Merged

Udate Readme and UI #348

merged 5 commits into from
Jun 23, 2024

Conversation

lmagyar
Copy link
Contributor

@lmagyar lmagyar commented May 27, 2024

A bit reformatted the Readme. :)

And added info about permanent SAF access.

  • You wrote on the UI: "From time to time permission might be revoked and you have to re-select." This happened to me, and made me mad.
  • First I configured the power settings, that the app is never got killed by Android. After this the permission is lost only when I closed the app completely.
  • I've noticed a "Directory access" permission that all my apps have that are able to write the SD card, and pftpd hasn't been on the list. (Android 9.0)
  • I've selected a subfolder on the SD card, and it got there! Then selected the SD card root, and remained there! From now on I can close the app completely, and when restarted SAF works again. Even after days. Fingers crossed.

Though it is strange, that I don't remember that I had to do this trick for the other apps. I've checked the source of Markor, and couldn't figure out the root cause of the difference (note: I'm a total newbie in case of Android dev).

@wolpi
Copy link
Owner

wolpi commented Jun 8, 2024

Oh no!
The new text-key got copied to many (all?) translation files. The intention was that it would not be present there and people know they have to add it.

@lmagyar
Copy link
Contributor Author

lmagyar commented Jun 8, 2024

OK, please tell me what to do, I really don't know how to manage translations with Weblate.

So, I revert all the renames in the translation files, except the original english, and leave this as is? What will happen when there is no V2 string in an non-english language?

    <TextView
        android:id="@+id/safExplain"
        android:layout_width="fill_parent"
        android:layout_height="wrap_content"
        android:gravity="center_horizontal"
        android:text="@string/safExplainV2"
        />

@wolpi
Copy link
Owner

wolpi commented Jun 9, 2024

So, I revert all the renames in the translation files, except the original english, and leave this as is?

Yes, exactly.

What will happen when there is no V2 string in an non-english language?

They will fallback to english.
That is why the english file lives in folder "values" (without language code). That is the behavior I want to have. Old tanslation shall not be shown anymore. If some language does not have the new text it shall show the english one. We cannot rely on translators providing a new text.

@wolpi
Copy link
Owner

wolpi commented Jun 9, 2024

I merged recent weblate changes today, that leads to conflict in this PR. Probably the conflict would just be resolved with removing the new text-key from all the translation files.

@lmagyar
Copy link
Contributor Author

lmagyar commented Jun 9, 2024

They will fallback to english. That is why the english file lives in folder "values" (without language code). That is the behavior I want to have. Old tanslation shall not be shown anymore. If some language does not have the new text it shall show the english one. We cannot rely on translators providing a new text.

Oh, now I understand! :) Clever trick! Better to show an updated english, than an old translation!

@lmagyar
Copy link
Contributor Author

lmagyar commented Jun 9, 2024

It's done. Tested, Hungarian version shows the new English text. 👍

I will add more Hungarian translations, but that is 10 times more tiring, than writing code. :D

@wolpi wolpi added this to the 7.2 milestone Jun 23, 2024
@wolpi wolpi merged commit eb27695 into wolpi:master Jun 23, 2024
1 check passed
@wolpi
Copy link
Owner

wolpi commented Jun 23, 2024

Thanks 🎉

wolpi added a commit that referenced this pull request Jun 23, 2024
@lmagyar lmagyar deleted the pr-update-readme-and-ui branch June 23, 2024 10:59
lmagyar pushed a commit to lmagyar/prim-ftpd that referenced this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants