Do not create sample authorized_keys file at old location #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, makes sense. Probably the creation of sample file would fail anyway as there is no write permission in old location with recent android versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I see, the new location is at:
/storage/emulated/0/Android/data/org.primftpd/files/.sshBut the app also reads all the old locations at
/storage/emulated/0/.ssh/authorized_key/storage/emulated/0/.ssh/authorized_key.pubOn start it creates a sample file if there is no file. But it creates the sample at one of the old locations also. I don't see why is it necessary. This was comitted this way originally, hasn't changed, but I think we shouldn't create a sample file at an "old" location.