Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
One issue with the code below:
/valid-folder/invalid-folder/valid-folder/file.xxx
, what should we do withinvalid-folder
???/valid-folder/invalid-folder
and finally a file was created with the name ofinvalid-folder
, still not a good outcome. And without any error message.Possible better solutions:
throws Exception
and modify SftpSubsystem's code? I remember you don't like modifying the original server's code.