-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/214-v2: Fix Digital Wallets and Cash App Payment Issues in WooCommerce 9.8 #301
base: trunk
Are you sure you want to change the base?
Conversation
QA Update ✅I have verified this PR in the I tested the following on this branch:
Screen.Recording.2025-03-14.at.4.12.51.PM.movTesting Environment
Steps to Test- As mentioned in the PR description.
|
@opr / @senadir , pinging you guys as you're involved in the upstream issue: woocommerce/woocommerce#52473 Requesting review for the approach taken in this PR. |
Hi, thanks for working on this! I am unlikely to have time to review this until next week at the very earliest, if you have other folks who can help test/review this please could you reach out to them instead? Thanks 🙇🏼 |
Thank you for the workaround @Sidsector9 I think it's a valid, clean hack. I haven't tested the flow but the code make sense to me. |
All Submissions:
Changes proposed in this Pull Request:
deferExecution()
, a workaround that defers execution to the next event loop cycle to ensure state updates are committed.Things I tried that did DID NOT work.
useRef()
to persist the Token.useTransition()
to prioritize state updates.setTokenResult( ( prev ) => newToken )
.onSubmit()
insideuseEffect()
.queueMicrotask()
to delay execution.Closes #214
Closes #307
Steps to test the changes in this Pull Request:
Changelog entry