Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/292: Add support for WooCommerce's new Email Improvements feature added in 9.6 #310

Open
wants to merge 13 commits into
base: trunk
Choose a base branch
from

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Mar 16, 2025

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

This PR adds support for Email Previewer added in Woo 9.6.
I had to remove namespaces from Email Notification classes as it caused the preview to be shown at /wp-admin/admin.php?page=wc-settings&tab=email but the preview did not work inside each Email setting.

Closes #292

Steps to test the changes in this Pull Request:

Test emails with both Woo 9.8 beta and previous versions of Woo.

Changelog entry

Add - Support for WooCommerce's new Email Improvements feature.

@Sidsector9 Sidsector9 self-assigned this Mar 16, 2025
@Sidsector9 Sidsector9 requested a review from dkotter March 16, 2025 14:54
Copy link
Contributor

@dkotter dkotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. A few minor things and also seeing a couple PHPCS warnings that need cleaned up

@dkotter dkotter added the needs: UAT The Issue/PR needs to go through UAT label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WooCommerce Square emails produce errors in WooCommerce email settings preview
2 participants