Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all actions we use in our workflows to pull from specific pinned commits #313

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

dkotter
Copy link
Contributor

@dkotter dkotter commented Mar 18, 2025

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

In order to help protect against compromised actions, instead of including actions based on their major version (like v4), this PR switches all the actions we use to pull based on the commit hash from the latest release.

While this does impact maintenance a bit going forward, it ensures that we we're always using actions that we (hopefully) trust and if an action gets compromised (which happens) we don't have to worry that we're using a compromised action. This also goes along with what GitHub suggests.

Steps to test the changes in this Pull Request:

Ensure all our workflows still run as expected

Changelog entry

Dev - Update all third-party actions our workflows rely on to use versions based on specific commit hashes

@dkotter dkotter added this to the Future Release milestone Mar 18, 2025
@dkotter dkotter self-assigned this Mar 18, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this workflow was used for in the past but doesn't actually contain a valid workflow so it throws an error anytime code is pushed, so figured we might as well delete it

Copy link

Uploading zip...

Running test...
Test run completed.
Test Run Id 4766603
Test Type Display Woo E2E
Wordpress Version 6.7.2
Woocommerce Version 9.7.1
Php Version 7.4
Status failed
Test Result Aws Url https://woo-compatibility-dashboard-tests.s3.amazonaws.com/compatibility/2706fb7b-0560-46cb-81d8-42859636490d-d9f07ba6-4ecd-414f-b853-df288b3443f2/index.html
Is Development Yes
Woo Extension Square
Test Summary 418 total, 373 passed, 2 failed, 43 skipped.
Version 4.8.7
Result Url https://qit.woo.com?qit_results=4766603.qoN5FHfOi7ryaCAphDkVaexLnGbfvaiDONuTU5Ufh0OTaHkP47Rw2SwJUHJcp6CW

Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants