Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/21339 Change the spacing between buttons #21340

Closed
wants to merge 1 commit into from

Conversation

Agoni-0
Copy link
Contributor

@Agoni-0 Agoni-0 commented Oct 23, 2024

Fixes #


Description:

The related issue is issue#21339. The spacing between Reading Preferences and other buttons is not equal.


Solution:

The size of the Reading Preferences icon called by the previous code is 25dp, but the other icons are 24dp. And the original Reading Preferences icon is called by other codes. It fits well.
So, I create a new drawable file named ic_reader_preferences_white_24dp and change size to 24dp.


To Test:

Due to my lack of knowledge on how to test the Jetpack code, I did not conduct any testing. But this modification is very simple, and I think it is correct.


Regression Notes

  1. Potential unintended areas of impact

    None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    None.

  3. What automated tests I added (or what prevented me from doing so)

    None.


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Copy link

sonarcloud bot commented Oct 23, 2024

@Agoni-0 Agoni-0 closed this Oct 24, 2024
@Agoni-0 Agoni-0 deleted the issue/21339 branch October 24, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant