issue/21339 Change the spacing between buttons #21340
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description:
The related issue is issue#21339. The spacing between
Reading Preferences
and other buttons is not equal.Solution:
The size of the
Reading Preferences
icon called by the previous code is 25dp, but the other icons are 24dp. And the originalReading Preferences
icon is called by other codes. It fits well.So, I create a new drawable file named
ic_reader_preferences_white_24dp
and change size to 24dp.To Test:
Due to my lack of knowledge on how to test the Jetpack code, I did not conduct any testing. But this modification is very simple, and I think it is correct.
Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
None.
What automated tests I added (or what prevented me from doing so)
None.
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):