fix task2 for windows cmd #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyshephard
approved these changes
Jul 23, 2023
|
Only those with write access to this repository can merge pull requests. @kid-icarus could you help to merge this? Thanks. |
|
@thyecust any way you can test this in a unix environment? we don't currently have automation set up |
|
The same issue is present on other exercises as well, such as part 3. The root cause is that the copy function doesn't work when "to" is a directory in Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is concerned with #99.
My modification
copyfunction can not properly copy the cc file to the temporary folderThe filename, directory name, or volume label syntax is incorrect.on windows cmd.