Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TM-1759] add polygons manage to admins #717

Closed
wants to merge 2 commits into from
Closed

[TM-1759] add polygons manage to admins #717

wants to merge 2 commits into from

Conversation

egrojMonroy
Copy link
Collaborator

No description provided.

@egrojMonroy egrojMonroy requested a review from roguenet February 28, 2025 21:21
@roguenet
Copy link
Collaborator

I think this isn't appropriate because it gives admins of one framework access to the polygons in all frameworks (unless the policy in v3 is going to filter on framework, and if it is, why is a new permission needed in the first place?)

roguenet
roguenet reviewed Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@roguenet roguenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the same problem: it gives all admins access to all polygons. I don't see why we need to change the policies in this codebase at all. Please see my comments on the v3 policy PR.

@egrojMonroy egrojMonroy closed this Mar 3, 2025
@egrojMonroy egrojMonroy deleted the feat/TM-1759-ttc branch March 3, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roguenet roguenet roguenet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egrojMonroy @roguenet @pachonjcl