-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TM-1766] entity get and index site #995
base: staging
Are you sure you want to change the base?
Conversation
|
||
// @ts-ignore | ||
export const siteDataProvider: DataProvider = { | ||
// @ts-expect-error until we can get the whole DataProvider on Project DTOs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Site DTOs
instead of Project
for this copied comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
const { record } = useShowContext(); | ||
const createPath = useCreatePath(); | ||
|
||
const getReportsPath = (view: keyof typeof modules) => { | ||
if (!record) return; | ||
|
||
console.log("record", record); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove testing console.log calls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
resource: modules.project.ResourceName, | ||
type: "show", | ||
id: record?.project?.uuid ?? record?.projectUuid | ||
})} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be needed eventually, but it shouldn't be needed for this PR. This component is only used for report types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, reverting
@@ -29,6 +29,8 @@ const QuickActions: FC = () => { | |||
justifyContent: "space-between" | |||
}; | |||
|
|||
console.log("record", record); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
to={createPath({ | ||
resource: modules.project.ResourceName, | ||
type: "show", | ||
id: record?.project?.uuid ?? record?.projectUuid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this one is only used for sites, record?.projectUuid
should be fine here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
src/connections/Entity.ts
Outdated
|
||
const siteConnection = createGetEntityConnection<SiteFullDto>("sites", true); | ||
export const loadSite = connectionLoader(siteConnection); | ||
export const useSite = connectionHook(siteConnection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These appear to be a duplicate of fullSiteConnection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
This doesn't appear to address the PD |
Task Link