-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ethical ad div to nav bar #2308
Conversation
So that the footer script doesn't throw an error and kill the survey navigation javascript
What should we be seeing or not seeing here? |
sorry @plaindocs was trying to debug from the web interface, no action requested, forgot to mark it draft |
what happened: Sphinx-generated markup changed to include result:
Nothing was functionally broken - just sub-section navigation disappeared, and the data tables got REAL UGLY. Only affected the 2023 Results page, which doesn't use the default theme CSS (which accounted for extraneous Fixed page here: https://writethedocs-www--2308.org.readthedocs.build/surveys/salary-survey/2023/ |
@plaindocs it's NOW ready for review 🙏 |
Fix for JS and CSS issues on 2023 Salary Survey results page
📚 Documentation preview 📚: https://writethedocs-www--2308.org.readthedocs.build/