Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ethical ad div to nav bar #2308

Merged
merged 7 commits into from
Feb 21, 2025
Merged

add ethical ad div to nav bar #2308

merged 7 commits into from
Feb 21, 2025

Conversation

goatlady
Copy link
Collaborator

@goatlady goatlady commented Feb 5, 2025

Fix for JS and CSS issues on 2023 Salary Survey results page


📚 Documentation preview 📚: https://writethedocs-www--2308.org.readthedocs.build/

So that the footer script doesn't throw an error and kill the survey navigation javascript
@plaindocs
Copy link
Contributor

What should we be seeing or not seeing here?

@goatlady goatlady marked this pull request as draft February 19, 2025 08:08
@goatlady
Copy link
Collaborator Author

sorry @plaindocs was trying to debug from the web interface, no action requested, forgot to mark it draft

@goatlady goatlady marked this pull request as ready for review February 19, 2025 08:58
@goatlady
Copy link
Collaborator Author

what happened: Sphinx-generated markup changed to include <p> elements inside <li> and <td> elements (server update? default settings change?)

result:

  1. show/hide sub-sections JS in the left nav broke
  2. default <p> margins and padding were applied to every table cell

Nothing was functionally broken - just sub-section navigation disappeared, and the data tables got REAL UGLY.

Only affected the 2023 Results page, which doesn't use the default theme CSS (which accounted for extraneous <p> elements).

Fixed page here: https://writethedocs-www--2308.org.readthedocs.build/surveys/salary-survey/2023/
Broken page here: https://www.writethedocs.org/surveys/salary-survey/2023/

@goatlady goatlady requested a review from plaindocs February 19, 2025 09:28
@goatlady
Copy link
Collaborator Author

@plaindocs it's NOW ready for review 🙏

@plaindocs plaindocs enabled auto-merge (squash) February 21, 2025 05:37
@plaindocs plaindocs merged commit 35cccc9 into main Feb 21, 2025
7 checks passed
@plaindocs plaindocs deleted the goatlady-2023-survey-patch branch February 21, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants