-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add language selector in UI #449
base: master
Are you sure you want to change the base?
Conversation
Refactor the language selector in order to display a pre-styled popup/modal with the available languages and add to the initial login page and the sidebar. The refactor has to do only with the appearance that could fit well in both scenarios, as long as it is a reusable component.
Sorry for the delay in reviewing this! The current implementation looks great but I have a couple of suggestions:
Let me know what you think! 🙌 |
Sounds great! We actually changed the dropdown style because it didn't feel great in the sidebar the way it was before. Perhaps we could think of positioning the dropdown options container next to the sidebar, aligned with the select language element, whenever toggled. |
You're right about the sidebar, it might be weird to have a dropdown there. |
Great! We'll work on it that way, then. I believe in the Settings section it won't be a problem. Also, in Settings, do you intend to display the full labels in the dropdown, instead of only the flags/alpha-2 codes? |
Sorry for any back-and-forth on my part but I think that your initial approach of using full labels + flags would be the most user-friendly way to go, especially in the Settings section. |
Set language selector back to dropdown layout. The options are now available in the Login page, with only the alpha-2 code (flag) and in Settings with the full label. The Login page is not displaying the full label because it would turn the layout messy, overlapping the main description.
The selected language will be stored in the local storage. If the user didn't select any language, it will check if the browser language can be used, i.e., if there is a translator file for that language. If not, it will use the default one (English).
Thanks so much for your patience with all the feedback! After discussing further, we’ve been reconsidering the use of flags for the language options, especially for English. Since English isn’t tied exclusively to a single country, using a 🇺🇸 flag might feel a bit limiting or even misleading for some users. To handle this, we’re thinking it might be better to either:
If we go with the second option, we’ll need to account for nuances between the two, such as minor text differences, date formats or other regional conventions. It’s not a major blocker but something to keep in mind as we move forward. We’re happy to help with these adjustments if needed, but feel free to proceed in whichever way works best for the flow you have in mind. Let us know your thoughts! |
I got your point. Actually, I think both approaches will have pretty much the same impact on the flow. The hardest mission here would be discerning similar languages in the translation |
To keep things simple for now, we could go with a single english option using the current texts (no flag and no distinction between US or UK). This avoids any immediate complexity and we can of course revisit in the future if we decide to separate them into regional variations and add flags or more elaborate country-codes |
Refactor the language selector in order to display a pre-styled popup/modal with the available languages and add to the initial login page and the sidebar. The refactor has to do only with the appearance that could fit well in both scenarios, as long as it is a reusable component.