Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding test to ratio #279

Closed
wants to merge 4 commits into from
Closed

Adding test to ratio #279

wants to merge 4 commits into from

Conversation

sayantikaSSG
Copy link
Collaborator

@sayantikaSSG sayantikaSSG commented Mar 9, 2023 •
edited
Loading

Added ratio test with simple random sampling design. referred to #253

@sayantikaSSG sayantikaSSG mentioned this pull request Mar 9, 2023
Open
2 tasks
@smishr smishr changed the base branch from main to v0.1.1 March 14, 2023 08:14
@smishr
Copy link
Contributor

smishr commented Mar 14, 2023 •
edited
Loading

@sayantikaSSG

  • All PRs go into a side branch (right now v0.1.1), not in main directly. I fixed this, but make sure you select the other branch next time.
  • You are pushing from an unclean branch, it has bits and pieces from raking. Only the lines of tests are required.
  • @itsdebartha started PR Added tests for ratio.jl #278, and these tests are an addition to that. You can checkout and commit directly from his branch/PR. For now, I have manually copied the tests from here into the other PR

@smishr smishr closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smishr smishr Awaiting requested review from smishr

@ayushpatnaikgit ayushpatnaikgit Awaiting requested review from ayushpatnaikgit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sayantikaSSG @smishr