[Mac] Initial Variations implementation

[CartBlanche]

No description provided.

[CartBlanche]

Current L&F of
Variations Dialog:

Variations Tree Rendering:

[CartBlanche]

@vancura Could you please cast your eye over the screenshots above ^^

[vancura]

Hey,

• There's a huge space between dropdowns and buttons on the top image
• Wrong font size in the variation label (1pt lower, please)
• Please don't use "X" and "+" characters on add/remove. We have bitmaps for these.

[ermau]

@vancura I'm curious about the change from the popup to a dialog, what was the motivation?

[CartBlanche]

@vancura I don't have the bitmaps you speak of.

I have an add and remove image, but when used look like this, not like the figma...

If you have them, please send them to me.

[CartBlanche]

@vancura

Font - 1

Also please see my comment above about the missing images.

[ermau]

Bugs:

• Changing theme after having the add variation dialog creates two dialogs the next time you invoke it.
• Switch to dark mode, add a variant, unselect the mock and reselect it. The line is the wrong color.
• Plus seems to turn a wrong color when the dialog is open.
• Add a variant, deselect mock and reselect. Variant is now readonly?
• Add a variant in grouped mode, variant is readonly.

[ermau]

I think we might want to add another property that the auto-focus on property button press thing uses to focus. Default it to the first key view and make it virtual. For variant properties, the remove variant button is the thing that gets focused after pressing the property button and that doesn't seem like the ideal behavior.

[CartBlanche]

Due to time, I've added a separate issue with regard to the autofocus property button - #652

[ermau]

Due to time? This doesn't have a desirable behavior, it is not a separate issue.

[CartBlanche]

By Due to time, I'm talking about what Bill said. Also that desirable behaviour would be required if Variations was shipping, which at the moment, my understanding is that it is on hold. Hence why I set up the a separate issue. So that if it if we need to work on it again, there is already an issue for it. Also it isn't that the current behaviour is unusable. It makes sense when tabbing. The other scenario is what needs enhancing.

[ermau]

Variations are also intended for Form's use, they are outside of the scope of the discussion with Bill.

[CartBlanche]

By only passing the EditorView.NativeView.Subviews the recursion only traverses down the EditorContainer tree, thus avoiding the Variation buttons.

Believe I've addressed the last pending issue.