Fix incorrect std::string_view usage

[neo1973]

Description

In many places it was assumed that std::string_view::data() would return a null terminated string that only contains the slice the view is pointing at. This is in general not true.

Motivation and context

I became aware of this general issue when investigating #1748. This PR probably solved that issue but I'm not certain.

How has this been tested?

Test suite runs, YouTube works.

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

Checklist:

• I have read the Contributing document
• My code follows the Code Guidelines of this project
• My change requires a change to the Wiki documentation
• I have updated the documentation accordingly

[CastagnaIT]

in many places the use of string_view is intentional
so i dont agree in full this pr

all logs changes are confusing due to additional length input

LOG::LogF(LOGWARNING, "Skipped AdaptationSet with id: \"%.*s\", has no representations.",
              static_cast<int>(adpSet->GetId().length()), adpSet->GetId().data());

fwik all strings manged on ISA are null terminated, if it is missing there is to understand why

[neo1973]

all logs changes are confusing due to additional length input

Probably time to migrate to std::format?

fwik all strings manged on ISA are null terminated, if it is missing there is to understand why

This might very well be true, but someone who doesn't know the ins and outs of inputstream.adaptive has to check every time a function accepts a std::string_view if it in reality expects a c-style string.

See e.g.:

inputstream.adaptive/src/parser/HLSTree.cpp

Line 93 in d789f97

width = STRING::ToInt32(val.substr(0, pos));

This has been special cased in StringUtils:

inputstream.adaptive/src/utils/StringUtils.cpp

Lines 182 to 187 in d789f97

	int UTILS::STRING::ToInt32(std::string_view str, int fallback /* = 0 */)
	{
	int result = fallback;
	std::from_chars(str.data(), str.data() + str.size(), result);
	return result;
	}

Do the same for UTILS::STRING::ToUint32 and it won't work. And that's the main problem. You can't look at a function and be certain that is does the correct thing even if you use it according to its contract.