Fix selecting complex polygons/ #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishcakez
reviewed
Jun 16, 2018
lib/mariaex/row_parser.ex
Outdated
| @@ -369,6 +369,9 @@ defmodule Mariaex.RowParser do | |||
| defp decode_geometry(<<_len::8-little, srid::32-little, 1::8-little, 3::32-little, num_rings::32-little, rest::bits >>, fields, null_bitfield, acc, datetime, json_library) do | |||
| decode_rings(rest, num_rings, {srid, fields, null_bitfield, acc}, datetime, json_library) | |||
| end | |||
| defp decode_geometry(<<_len::8-little, _var_a::8-little, _var_b::8-little, srid::32-little, 1::8-little, 3::32-little, num_rings::32-little, rest::bits>>, fields, null_bitfield, acc, datetime, json_library) do | |||
There was a problem hiding this comment.
What are the _var_a and _var_b values? Are we able to match on these more?
There was a problem hiding this comment.
I would love to match and maybe do something useful with it, but I have no clue what they are or what they contain. If someone can shed some light on this, I would be happy to adapt the code.
* xerions-master: (23 commits) Update DBConnection git ref Update mariaex.ex Add Mariaex.prepare_execute Remove outdated pool config Update dbconnection reference Update types Fix return types Update docs Update to latest DBConnection Update to latest DBCOnnection Update to DBConnection 2.0 Raise DBConnection.ConnectionError on connection error Add max rows option to each cursor fetch Remove reserved query name errors Support explicit cursor API Use one text statement for all queries Use database transaction status to prevent transaction errors Update decimal Remove Docker dependent test Fix typespec and README for rows as lists not tuples ...
* upstream/master: Release v0.9.1 with timestamp as DateTime (in UTC) Release v0.9.0 Revert (for the prepared statements) irrelevant changes Use `""` as query name when prepare == :unnamed Remove unnecessary query sanitization Only sanitize query in the protocol module Add option `prepare` to overrule named prepare statements Improve test database setup Ignore .DS_Store Fix unused variable warnings Release 0.9.0-rc.0 Update to DBConnection 2.0-rc fix .travis.yml for MySQL 8.0 image This image can't load caching_sha2_password.so fix not applying :timeout in query options add auth plugin mechanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the issue and discussion see #224