Backport: Fix typespec rows as lists not tuples #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like it was changed from tuples to lists in 0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like it was changed from tuples to lists in 0.4
Cherrypicked from d00bc78
Sadly, it's difficult for me to upgrade mariaex to 0.9.1 because it requires I upgrade to db_connection 2.x which then requires I upgrade to ecto 3.x and the chain goes on to almost the entire project. Would you be willing to backport this fix and release it as v0.8.6 so I can get rid of the dialyzer errors without doing a full app upgrade?