merge from upstream #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/test-*.js doesn't seem to exist, so the test entry here makes no sense
FIX: Go back to regular dependencies, so that the package works on NPM <7.
prosemirorr-model's `addToSet` already handles de-duplication, there's no need for custom logic here. FIX: Make it possible to specify multiple marks of the same type for a given piece of content.
Until now, the only explicit return type of builder has been schema. Therefore, to use the builder in a TypeScript project, it had to be cast to any. This change provides a type that uses the schema and name of the builders argument to return the appropriate object. FIX: Make the return type of \`builders\` include properties for schema node/mark names.
FIX: Include CommonJS type declarations in the package to please new TypeScript resolution settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.