Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make target:filerule able to match package rules #5730

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

SirLynix
Copy link
Member

When trying to add files with a specific package rule within a package rule:

rule("foo")
    on_config(function (target)
        target:add("files", "bar", { rule = "@package/baz" })
    end)

the rule wasn't found by target:filerule(file), causing an unknown source file error.

This can be easily fixed by using the target:rule(file) method, I think we could replace the whole line with it but I put it as a fallback at the end to not break anything.

@waruqi waruqi merged commit 86627f2 into xmake-io:dev Oct 18, 2024
19 checks passed
@waruqi waruqi added this to the v2.9.6 milestone Oct 18, 2024
@SirLynix SirLynix deleted the patch-18 branch October 18, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants