refactor: remove duplicated assets folder #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nacho-alesina05
requested review from
fedecor9,
mirland and
nicolantean
as code owners
nicolantean
approved these changes
Nov 1, 2024
ios/Podfile.lock
Outdated
| @@ -1602,4 +1602,4 @@ SPEC CHECKSUMS: | |||
|
|
|||
| PODFILE CHECKSUM: f78dd2483182dea10382b361f51daf312ce67029 | |||
|
|
|||
| COCOAPODS: 1.15.2 | |||
| COCOAPODS: 1.13.0 | |||
There was a problem hiding this comment.
you have to update your cocoapods version
…n system assets folder
nacho-alesina05
force-pushed
the
refactor/assets-management
branch
from
39721dd
to
a40d472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Refactor
✏️ Description:
This PR removes the duplicated assets folder. By enabling the package_parameter_enabled flag in the design system’s pubspec.yaml file, assets are generated specifically for a package. The assets class is named DsAssets. Therefore, after generating it in the design system, files that previously referenced the old Assets class now need to be updated. This involves changing the package reference to the one generated by the design system and replacing Assets with DsAssets.
Also, the autocorrect flag in the email text input was set to false.