Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubyzip gem no longer requires the zip class prefix #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fontno
Copy link

@fontno fontno commented Apr 16, 2014

Just a quick fix. When I ran the rails passbook:config generator I received these errors

rails g passbook:config
/Users/Brian/forks/xl-passbook-ruby/lib/passbook/pkpass.rb:23:in `require': cannot load such file -- zip/zipfilesystem (LoadError)
    from /Users/Brian/forks/xl-passbook-ruby/lib/passbook/pkpass.rb:23:in `<top (required)>'
rails g passbook:config
/Users/Brian/forks/xl-passbook-ruby/lib/passbook/pkpass.rb:23:in `require': cannot load such file -- zipfilesystem (LoadError)
    from /Users/Brian/forks/xl-passbook-ruby/lib/passbook/pkpass.rb:23:in `<top (required)>'

It seems Rubyzip made some changes.
https://github.com/rubyzip/rubyzip#important-note

"Rubyzip interface changed!!! No need to do require "zip/zip" and Zip prefix in class names removed."

Thanks for releasing this gem. It has been a great help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant