forked from diaspora/diaspora
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request diaspora#4387 from MrZYX/refactor_twitter
refactor twitter service model
- Loading branch information
Showing
3 changed files
with
102 additions
and
93 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,103 +1,111 @@ | ||
| class Services::Twitter < Service | ||
| include ActionView::Helpers::TextHelper | ||
| include Rails.application.routes.url_helpers | ||
| include MarkdownifyHelper | ||
|
|
||
| MAX_CHARACTERS = 140 | ||
| SHORTENED_URL_LENGTH = 21 | ||
|
|
||
| LINK_PATTERN = %r{https?://\S+} | ||
|
|
||
| def provider | ||
| "twitter" | ||
| end | ||
|
|
||
| def post(post, url='') | ||
| Rails.logger.debug("event=post_to_service type=twitter sender_id=#{self.user_id}") | ||
| (0...20).each do |retry_count| | ||
| begin | ||
| message = build_twitter_post(post, url, retry_count) | ||
| @tweet = client.update(message) | ||
| break | ||
| rescue Twitter::Error::Forbidden => e | ||
| if e.message != 'Status is over 140 characters' || retry_count == 20 | ||
| raise e | ||
| end | ||
| end | ||
| end | ||
| post.tweet_id = @tweet.id | ||
| def post post, url='' | ||
| Rails.logger.debug "event=post_to_service type=twitter sender_id=#{self.user_id}" | ||
| tweet = attempt_post post | ||
| post.tweet_id = tweet.id | ||
| post.save | ||
| end | ||
|
|
||
| def adjust_length_for_urls(post_text) | ||
| real_length = post_text.length | ||
| URI.extract( post_text, ['http','https'] ) do |a_url| | ||
| # add or subtract from real length - urls for tweets are always | ||
| # shortened to SHORTENED_URL_LENGTH | ||
| if a_url.length >= SHORTENED_URL_LENGTH | ||
| real_length -= a_url.length - SHORTENED_URL_LENGTH | ||
| else | ||
| real_length += SHORTENED_URL_LENGTH - a_url.length | ||
| end | ||
| def profile_photo_url | ||
| client.user(nickname).profile_image_url_https "original" | ||
| end | ||
|
|
||
| def delete_post post | ||
| if post.present? && post.tweet_id.present? | ||
| Rails.logger.debug "event=delete_from_service type=twitter sender_id=#{self.user_id}" | ||
| delete_from_twitter post.tweet_id | ||
| end | ||
| return real_length | ||
| end | ||
|
|
||
| def add_post_link(post, post_text, maxchars) | ||
| post_url = Rails.application.routes.url_helpers.short_post_url( | ||
| post, | ||
| :protocol => AppConfig.pod_uri.scheme, | ||
| :host => AppConfig.pod_uri.authority | ||
| ) | ||
| truncated_text = truncate post_text, length: maxchars - SHORTENED_URL_LENGTH + 1 | ||
| truncated_text = restore_truncated_url truncated_text, post_text, maxchars | ||
| private | ||
|
|
||
| "#{truncated_text} #{post_url}" | ||
| def client | ||
| @client ||= Twitter::Client.new( | ||
| oauth_token: self.access_token, | ||
| oauth_token_secret: self.access_secret | ||
| ) | ||
| end | ||
|
|
||
| def build_twitter_post(post, url, retry_count=0) | ||
| maxchars = MAX_CHARACTERS - retry_count*5 | ||
| post_text = strip_markdown(post.text(:plain_text => true)) | ||
| #if photos, always include url, otherwise not for short posts | ||
| if adjust_length_for_urls(post_text) > maxchars || post.photos.any? | ||
| post_text = add_post_link(post, post_text, maxchars) | ||
| def attempt_post post, retry_count=0 | ||
| message = build_twitter_post post, retry_count | ||
| tweet = client.update message | ||
| rescue Twitter::Error::Forbidden => e | ||
| if e.message != 'Status is over 140 characters' || retry_count == 20 | ||
| raise e | ||
| else | ||
| attempt_post post, retry_count+1 | ||
| end | ||
| return post_text | ||
| end | ||
|
|
||
| def profile_photo_url | ||
| client.user(nickname).profile_image_url_https("original") | ||
| def build_twitter_post post, retry_count=0 | ||
| max_characters = MAX_CHARACTERS - retry_count * 5 | ||
|
|
||
| post_text = strip_markdown post.text(plain_text: true) | ||
| truncate_and_add_post_link post, post_text, max_characters | ||
| end | ||
|
|
||
| def delete_post(post) | ||
| if post.present? && post.tweet_id.present? | ||
| Rails.logger.debug("event=delete_from_service type=twitter sender_id=#{self.user_id}") | ||
| delete_from_twitter(post.tweet_id) | ||
| end | ||
| def truncate_and_add_post_link post, post_text, max_characters | ||
| return post_text unless needs_link? post, post_text, max_characters | ||
|
|
||
| post_url = short_post_url( | ||
| post, | ||
| protocol: AppConfig.pod_uri.scheme, | ||
| host: AppConfig.pod_uri.authority | ||
| ) | ||
|
|
||
| truncated_text = truncate post_text, length: max_characters - SHORTENED_URL_LENGTH + 1 | ||
| truncated_text = restore_truncated_url truncated_text, post_text, max_characters | ||
|
|
||
| "#{truncated_text} #{post_url}" | ||
| end | ||
|
|
||
| def delete_from_twitter(service_post_id) | ||
| client.status_destroy(service_post_id) | ||
| def needs_link? post, post_text, max_characters | ||
| adjust_length_for_urls(post_text) > max_characters || post.photos.any? | ||
| end | ||
|
|
||
| private | ||
| def client | ||
| @client ||= Twitter::Client.new( | ||
| oauth_token: self.access_token, | ||
| oauth_token_secret: self.access_secret | ||
| ) | ||
| def adjust_length_for_urls post_text | ||
| real_length = post_text.length | ||
|
|
||
| URI.extract(post_text, ['http','https']) do |url| | ||
| # add or subtract from real length - urls for tweets are always | ||
| # shortened to SHORTENED_URL_LENGTH | ||
| if url.length >= SHORTENED_URL_LENGTH | ||
| real_length -= url.length - SHORTENED_URL_LENGTH | ||
| else | ||
| real_length += SHORTENED_URL_LENGTH - url.length | ||
| end | ||
| end | ||
|
|
||
| real_length | ||
| end | ||
| def restore_truncated_url truncated_text, post_text, maxchars | ||
| return truncated_text if truncated_text !~ /#{LINK_PATTERN}\Z/ | ||
|
|
||
| url = post_text.match(LINK_PATTERN, truncated_text.rindex('http'))[0] | ||
| truncated_text = truncate( | ||
| post_text, | ||
| length: maxchars - SHORTENED_URL_LENGTH + 2, | ||
| separator: ' ', | ||
| omission: '' | ||
| ) | ||
|
|
||
| def restore_truncated_url truncated_text, post_text, max_characters | ||
| return truncated_text if truncated_text !~ /#{LINK_PATTERN}\Z/ | ||
|
|
||
| url = post_text.match(LINK_PATTERN, truncated_text.rindex('http'))[0] | ||
| truncated_text = truncate( | ||
| post_text, | ||
| length: max_characters - SHORTENED_URL_LENGTH + 2, | ||
| separator: ' ', | ||
| omission: '' | ||
| ) | ||
|
|
||
| "#{truncated_text} #{url} ..." | ||
| end | ||
|
|
||
| def delete_from_twitter service_post_id | ||
| client.status_destroy service_post_id | ||
| end | ||
| end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters