XWIKI-22316: Some elements keep main theme CSS values #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated the Applications Panel to use the document style * Updated the Notification displayer UIX to use the document style * Removed style for the Colibri skin in order to use new color theme variables in the application panel. * Removed useless calls to colorThemeInit.vm at the start of ssxs (and set the parsing off for those.)
Sereza7
added
the
backport stable-15.10.x
surli
reviewed
Aug 27, 2024
| -webkit-border-radius: 7px; | ||
| border-radius: 7px; | ||
| margin: 1px 0; | ||
| } |
There was a problem hiding this comment.
Not sure why you removed those changes?
There was a problem hiding this comment.
It was just cleaning up old code related to colibri, which we don't support anymore since 6.4 .
https://extensions.xwiki.org/xwiki/bin/view/Extension/Colibri%20Skin
It was moved to contrib and IMO this code has little use being in the code base. Since this PR needed an update of the SSX, I thought it would be okay to clean it up a bit here directly.
Did I get something wrong?
|
Note: I wouldn't backport this to LTS. |
Sereza7
added
backport stable-16.4.x
and removed
backport stable-15.10.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22316
Changes
Description
Clarifications
Screenshots & Video
2024-07-11.14-54-25.mp4
We can see here that I used multiple color themes, one for each of: main page, sandbox, application panel document, notification UIX document.
On all of those the elements follow the current colorTheme of the document and not the one from where they are defined.
Executed Tests
Only manual tests, UIX content only, focused on style, I don't think there's any automatic coverage for this.
Expected merging strategy