Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display metadata in the table #1462

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

akirk
Copy link

@akirk akirk commented Oct 11, 2023

Fixes #947.

The metadata that can be stored along side records is burried in the stream_meta table. This make the data accessible in the table.

metadata-display

Checklist

  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

I have run the code. I am unable to run the local development environment on a recent Macbook Pro. Maybe the environment should be updated in a separate PR.

Error: Cask virtualbox depends on hardware architecture being one of [{:type=>:intel, :bits=>64}], but you are running {:type=>:arm, :bits=>64}.

Thus, I have also not been able to check the unit tests yet.

Release Changelog

  • New: Expose stream metadata in the admin UI.

Release Checklist

  • This pull request is to the master branch.
  • Release version follows semantic versioning. Does it include breaking changes?
  • Update changelog in readme.txt.
  • Bump version in stream.php.
  • Bump Stable tag in readme.txt.
  • Bump version in classes/class-plugin.php.
  • Draft a release on GitHub.

Change [ ] to [x] to mark the items as done.

@akirk
Copy link
Author

akirk commented Feb 8, 2024

@kasparsd any chance of getting this merged? I've rebased this on the current release, it still works.

@hokoo
Copy link

hokoo commented Apr 6, 2024

Nice to have an option like "Retrieve meta data to display" in order to not overload DB when it is not needed.

@marcinkrzeminski
Copy link
Collaborator

@akirk thanks for the PR. I agree that it would be best to make this feature optional. Do you have the capacity to add a setting that enables it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta not included into Record object?
3 participants