-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaner rem-values, fixed input zoom mobile #25
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/x-z/new-css/4tedwc9fo |
new.css
Outdated
overflow-x: hidden; | ||
word-break: break-word; | ||
overflow-wrap: break-word; | ||
background: var(--nc-bg-1); | ||
|
||
/* Main body text */ | ||
color: var(--nc-tx-2); | ||
font-size: 1.03rem; | ||
font-size: 1rem; /* make fonts more crispy to 16px */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to define it, as it is automatically inherited from the parent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw that you wrote the following:
added font-size: 1rem; to text input fields to prevent zooming in mobile browsers
Maybe update the comment to explain how and why this works? Maybe a link to an article? That way we avoid that people like me will make a PR to remove it again ;)
new.css
Outdated
@@ -106,8 +106,9 @@ h1, | |||
h2, | |||
h3 { | |||
color: var(--nc-tx-1); | |||
padding-bottom: 2px; | |||
margin-bottom: 8px; | |||
padding-bottom: .25rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caillou So focusing this PR on the zoom fix? Will update it then accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted and updates most of the stuff. Feel welcome to review my commit eb95f5c
…ss#25 and adjusted home text
All font sizes will be reworked in 2.0.0 update, most likely with a Using For iOS input shadows, I will leave #26 open for discussion. For now, I think it would be best to leave the default styling. For future reference, this shadow still exists in Safari on iOS 14.3. |
Small updates which enhances the CSS quality
border-radius
1rem
1.3