Avoid anonymous structs and unions #235
Open
+16
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale: ocaml-yaml bindings need to probe their size at compile time. For this reason, it vendors libyaml with a modified include file, which is not reasonable. See: https://github.com/avsm/ocaml-yaml/blob/master/vendor/README.md
glondu
force-pushed
the
avoid-anonymous
branch
from
5f09f14
to
9a7de23
Compare
ingydotnet
approved these changes
Jan 29, 2023
|
It would be useful for Fedora to have this upstream. |
|
What prevents this from being merged (and released)? |
|
It would be nice to have this PR merged so that we could have Debian/Ubuntu packages... Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: ocaml-yaml bindings need to probe their size at compile
time. For this reason, it vendors libyaml with a modified include
file, which is not reasonable.
See: https://github.com/avsm/ocaml-yaml/blob/master/vendor/README.md