-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SSR] Fix window undefined bug #79
[SSR] Fix window undefined bug #79
Conversation
Again, please only make changes to |
Crap sorry, I thought you meant not to mess with |
revert version
It can be helpful but let's split different concerns into their own PR. |
remove develop
I still stand by #71 (comment), but I think this solution is much cleaner. |
space
While I don't disagree with #71, practically, I don't believe that metafizzy will change their position anytime soon. In terms of React, server side rendering solutions are becoming much more approachable and popular so why not accommodate react developer using isomorphic or static with literally one line of code? :) |
Thank you for your work @pr1ntr ! |
Leaving a comment here incase anyone is using flickity-fade and wondering why they're still getting the You have to use the same fix here - #4 (comment) - i.e
...to fix the issue. Hope this saves someone a couple of hours of digging. |
flickity will call window as soon as its imported. In order to use with SSR it must be required on componentDidMount
This fix is confirmed working in Gatsby.
This is a new PR in in lieu of #78