Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: don't use .ts for unknown extension tests #6649

Merged
merged 2 commits into from
Feb 3, 2025
Merged

test: don't use .ts for unknown extension tests #6649

merged 2 commits into from
Feb 3, 2025

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jan 7, 2025

What's the problem this PR addresses?

.ts isn't an unknown extension any more after https://github.com/nodejs/node/releases/tag/v23.6.0.

How did you fix it?

Replace .ts with .foo.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@RDIL RDIL added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit 0387ee7 Feb 3, 2025
26 checks passed
@RDIL RDIL deleted the merceyz/test/don't-use-ts-for-unknown-extension branch February 3, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RDIL RDIL RDIL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merceyz @RDIL