-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filestore] Implement a tool which replays filestore-vhost's profile log #2124
Open
proller
wants to merge
83
commits into
ydb-platform:main
Choose a base branch
from
proller:issues-1733-replay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,389
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log - part0: prepare
debnatkh
reviewed
Nov 7, 2024
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp
Outdated
Show resolved
Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp
Outdated
Show resolved
Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp
Outdated
Show resolved
Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp
Outdated
Show resolved
Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp
Outdated
Show resolved
Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp
Outdated
Show resolved
Hide resolved
debnatkh
requested changes
Nov 11, 2024
std::move(spec), | ||
std::move(logging), | ||
std::move(session), | ||
std::move(filesystemId), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nbs/cloud/filestore/libs/client/durable.cpp
Lines 119 to 129 in 79223f7
TDurableClientBase( | |
ILoggingServicePtr logging, | |
ITimerPtr timer, | |
ISchedulerPtr scheduler, | |
IRetryPolicyPtr retryPolicy, | |
std::shared_ptr<TClient> client) | |
: Logging(std::move(logging)) | |
, Timer(std::move(timer)) | |
, Scheduler(std::move(scheduler)) | |
, RetryPolicy(std::move(retryPolicy)) | |
, Client(std::move(client)) |
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp
Outdated
Show resolved
Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp
Outdated
Show resolved
Hide resolved
debnatkh
requested changes
Nov 13, 2024
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp
Outdated
Show resolved
Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp
Outdated
Show resolved
Hide resolved
В другом пр договорились добавить тесты с канонизацией результатов и с походами по grpc api |
debnatkh
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1733